Read attributes as provided by the event object, and pass on attributes to other event handlers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteWunsch
added a commit
to webfactory/WebfactoryHttpCacheBundle
that referenced
this pull request
Nov 19, 2024
…es to other event handlers (Case 177753) (#15) This adapts webfactory/WebfactoryWfdMetaBundle#53: > This PR uses the new API introduced in symfony/symfony#46001 to read controller attributes through the `ControllerEvent`, and to make them available to other event handlers when replacing the controller. > > This is necessary when using the `Send304IfNotModified` attribute in combination with `\Symfony\Component\HttpKernel\Attribute\Cache`. Without this change, `\Symfony\Component\HttpKernel\EventListener\CacheAttributeListener` will not set `Cache` headers accordingly. The result is that you may get `304 Not Modified` responses on conditional requests with `If-Modified-Since`, but these are treated as `stale/cache` only in the HttpCache and have a `Cache-Control: must-revalidate, private` header. And adds some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new API introduced in symfony/symfony#46001 to read controller attributes through the
ControllerEvent, and to make them available to other event handlers when replacing the controller.This is necessary when using the
Send304IfNotModifiedattribute in combination with\Symfony\Component\HttpKernel\Attribute\Cache. Without this change,\Symfony\Component\HttpKernel\EventListener\CacheAttributeListenerwill not setCacheheaders accordingly. The result is that you may get304 Not Modifiedresponses on conditional requests withIf-Modified-Since, but these are treated asstale/cacheonly in the HttpCache and have aCache-Control: must-revalidate, privateheader.